Added hot-reload support for branding file (logo, css, favicon) #14499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Phillip Kruger <[email protected]>
ghost
added
gsmet
approved these changes
Jan 25, 2021
|
I merged it. That being said, I'm not sure I want to backport it. It seems like a relatively narrow issue and the changes are consequent. I could be convinced but my first inclination would be to not backport it. @phillip-kruger WDYT? |
|
Hi @gsmet - Yea I am happy if this wait for 1.12.0. Just thought that it's fixing a "bug" kind of, might be cool to get it earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14431
This PR adds hot-reload support for branding files on all UIs (GraphQL, Health and Swagger UI)
You can now start your application in dev mode, and start adding content (logo, css, favicon) or update the content, and the changes is visible on browser reload.
I also added a fallback for
applicationNameandapplicationVersionwhen they are not available.Signed-off-by:Phillip Kruger [email protected]