Security fixes for RESTEasy Reactive #14563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stuartwdouglas
commented
Jan 25, 2021
stuartwdouglas
commented
- Add ability to deny access to unannotated endpoints
- Make sure setSecurityContext changes the current identity
- Port tests from RESTEasy extension
Injection of the SecurityContext will result in using the same SecurityContext for all requests.
- Add ability to deny access to unannotated endpoints - Make sure setSecurityContext changes the current identity - Port tests from RESTEasy extension
ghost
added
area/dependencies
geoand
reviewed
Jan 25, 2021
| import io.quarkus.runtime.annotations.ConfigRoot; | ||
|
|
||
| /** | ||
| * @author Michal Szynkiewicz, [email protected] |
There was a problem hiding this comment.
Maybe drop these author tags which are incorrect anyway?
| private CurrentIdentityAssociation getCurrentIdentityAssociation() { | ||
| CurrentIdentityAssociation identityAssociation = this.currentIdentityAssociation; | ||
| if (identityAssociation == null) { | ||
| return this.currentIdentityAssociation = CDI.current().select(CurrentIdentityAssociation.class).get(); |
There was a problem hiding this comment.
Probably best to be consistent and use Arc.container() instead of CDI.current()
|
Also I believe this should be backported, right? |
|
I think we really need this in for 1.11.1.Final. Looks like the comments are mostly about details? I can fix them myself or we can merge as is. @geoand WDYT? |
Sure yeah, we can definitely merge as is |
gsmet
approved these changes
Jan 26, 2021
|
OK, let's merge it then. This can't stay as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.