Fix RESTEasy ImageIO leak #14700
Fix RESTEasy ImageIO leak #14700
Conversation
We decided to disable the IIOImageProvider in RESTEasy a long time ago but a new method was added and it defeated this optimization. Fix quarkusio#14674
This way, we will have a GraalVM error if a new method makes use of it instead of silently including ImageIO.
ghost
added
the
|
This looks good to me. I've confirmed on a local build of quarkus 1.11 with this patch, non-graphics apps no longer pull in that stack for no reason. |
|
Thanks for confirming @jerboaa ! |
|
@gsmet this indeed fixes the issue for most tests but we still see issues on the following tests:
IT main (which includes ImageIOTestCase) and IT tika are known to have dependencies on AWT, but what about the rest? |
|
When debugging Is this expected? |
|
I'm guessing it's a different issue, but causing a similar problem. |
|
As for the rest of the problematic tests, it looks like they all depend on JAXB explicitly and I think the behavior was probably preexisting. Note that even for RESTEasy, that might be something we would want to reconsider now that we have proper ImageIO support. The provider detection works well IF the consumes/produces are properly defined and in this case, the provider is not included. We didn't have any report asking for this support so far so we can keep it like that for now but that's something we might reconsider later. |
No description provided.