Prevent ISE duplicate key when checking if instrumentation can be used #14765
Conversation
ghost
added
the
| @@ -100,7 +100,7 @@ static boolean compareAnnotations(Collection<AnnotationInstance> a, Collection<A | |||
| return false; | |||
| } | |||
| Map<DotName, AnnotationInstance> lookup = b.stream() | |||
| .collect(Collectors.toMap(AnnotationInstance::name, Function.identity())); | |||
| .collect(Collectors.toMap(AnnotationInstance::name, Function.identity(), (i1, i2) -> i1)); | |||
There was a problem hiding this comment.
Do you really want to ignore the second one?
|
What actually causes this? There should not be a situation where there are duplicate annotations. |
|
@evacchi should have a reproducer for this - he just mentioned in chat, I didn't have an actual example |
|
Is it with latest Quarkus? Because we had a bug in method comparisons triggering exactly this. Martin fixed it and I believe it’s in 1.11.1.Final. |
|
I had this issue with one of the examples with Quarkus 1.11.x IIRC -- sorry couldn't come up with a stand-alone reproducer yet. Had two separate issues, this one with
|
|
Could someone have a look at this? I won't have the time to check it and PRs are piling up. Looks like something we would want fixed for 1.11.2.Final. |
|
I'll try tomorrow but I can make no guarantees as there is a ton of (high priority) work pilling up |
|
In any case, #14775 provides a way to disable instrumentation altogether so we should definitely get that one in |
|
yesterday I could not reproduce this on our master, so no need to rush it. Moreover, the flag to disable instrumentation should be helpful as well. |
|
@evacchi have you had any more troubles with this? If not, I can close this |
|
let's close it for now @geoand |
No description provided.