Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to smallrye-jwt-2.4.3 #14815

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Update to smallrye-jwt-2.4.3 #14815

merged 1 commit into from
Feb 4, 2021

Conversation

sberyozkin
Copy link
Member

Also fixes #14450.

@sberyozkin sberyozkin requested a review from gastaldi February 4, 2021 10:05
@ghost ghost added the area/dependencies Pull requests that update a dependency file label Feb 4, 2021
@sberyozkin sberyozkin added this to the 1.12 - master milestone Feb 4, 2021
@gsmet
Copy link
Member

gsmet commented Feb 4, 2021

@sberyozkin is it something that should be backported?

@sberyozkin
Copy link
Member Author

Hi @gsmet it improves on a few things in the build API (better control of the claim object types), aligns the key location property names with the verification key locations, and also supports the key rotation for the HTTP-only based key sets - but here it uses a new mechanism compared to 2.4.2 - so there might be a low risk here. So I guess it is OK to keep it for 1.12.0 only.

@sberyozkin
Copy link
Member Author

@gastaldi thanks; I forgot to update the docs as 2 build api props have been deprecated and new ones aligning with the existing smallrye-jwt naming pattern for the verification keys (as also requested by the Quarkus user) have been added. I'll update you ince I force-push

@ghost ghost added the area/documentation label Feb 4, 2021
@sberyozkin
Copy link
Member Author

@gastaldi @gsmet did a doc update as well

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 4, 2021
@sberyozkin
Copy link
Member Author

MP context-propagation tests have had some problem, so I've restarted

@sberyozkin sberyozkin merged commit 15d6405 into quarkusio:master Feb 4, 2021
@sberyozkin sberyozkin deleted the smallrye_jwt_2.4.3 branch February 4, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.12.0.CR1
Development

Successfully merging this pull request may close these issues.

Quarkus JWT producing 401 errors using @RolesAllowed
3 participants
@sberyozkin @gsmet @gastaldi