Verify behavior of micrometer matchPattern #14859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebullient
changed the title
|
Test failures look related (but you need to have a look at the raw logs). But the output is so weird I wasn't able to isolate what's going wrong quickly. Probably worth to improve things a bit on this front. |
|
Y.. I'm expecting this one to be all over the map for now. Definitely related. That's why I said this wasn't ready yet in the comment above. ;) For some reason, the CI build didn't run at first.. |
ghost
added
the
kenfinnigan
approved these changes
Feb 8, 2021
|
Do not merge w/o one pending fix (to disable trace again) that I'm holding until CI clears up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14813