Set the default min-level for logs to DEBUG #14917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion with Max. Note that the related ITs might need some tweaks as the default value has changed but they will need to be changed later.
ghost
added
maxandersen
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
+1 LGTM
The previous PR approval did not consider fully the UX impact and the perf hit is mainly due to vert.x TRACE and many use DEBUG for basic debugging. so better logic is to allow DEBUG to work, and require extra step for tracing.
Users who really have hot code paths with lots of DEBUG can then explicily set min-level to gain some extra %.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with Max.
Note that the related ITs might need some tweaks as the default value
has changed but they will need to be changed later.