Allow to exclude JAX-RS classes with annotations

[essobedo]

fixes #15214

Motivation

The idea of this feature is to provide an easy way to include/exclude JAX-RS resource, provider and feature classes at build time by relying on the build time conditions

Modifications:

• Makes ResteasyReactiveCommonProcessor#handleApplication and ResteasyServerCommonProcessor#build depend on BuildTimeConditionBuildItem to have access to all computed build time conditions.
• Adds a method getExcludedClasses to both extensions to retrieve the list of classes that need to be excluded
• Adds the property buildTimeConditionAware to both extensions to be able to disable the feature if needed knowing that it is enabled by default
• Ensures that the feature will be disabled if a JAX-RS Application with classes to include has been defined
• Adds a new build item PreAdditionalBeanBuildTimeConditionBuildItem to be able evaluate build time conditions before processing AdditionalBeanBuildItem to avoid a circular dependency.

Result

The JAX-RS classes can now be included/excluded thanks to the build time conditions

[geoand]

Thanks for this work!

I like the idea, but I have a couple hesitations:

1. I don't think it will work properly for RESTEasy Classic for anything besides JAX-RS Resources
2. If we have support for IfBuildProfile, we should also have support for UnlessBuildProfile

[essobedo]

Thanks for this work!

I like the idea, but I have a couple hesitations:

1. I don't think it will work properly for RESTEasy Classic for anything besides JAX-RS Resources
2. If we have support for IfBuildProfile, we should also have support for UnlessBuildProfile

@geoand I'm glad that you like the idea 😄

About your remark:

1. If you check well in my PR I cover both (classic and reactive) and according to my ITs it works on both unless I miss your point
2. The PR actually covers IfBuildProfile, UnlessBuildProfile, IfBuildProperty and UnlessBuildProperty as you can see in the IT

[geoand]

Thanks for this work!
I like the idea, but I have a couple hesitations:

1. I don't think it will work properly for RESTEasy Classic for anything besides JAX-RS Resources
2. If we have support for IfBuildProfile, we should also have support for UnlessBuildProfile

@geoand I'm glad that you like the idea

About your remark:

1. If you check well in my PR I cover both (classic and reactive and according) to my IT it works on both unless I miss your point

Yeah, I saw that. I am just sceptical that some other use case will come along that won't work.
For RESTEasy Reactive I am confident it will work :)

2. The PR actually covers IfBuildProfile, UnlessBuildProfile, IfBuildProperty and UnlessBuildProperty as you can see in the IT

Well, I don't see that actually :P

[essobedo]

Well, I don't see that actually :P

@geoand In the Integration Test you have:

• IfBuildProfile here
• UnlessBuildProfile here
• IfBuildProperty here
• UnlessBuildProperty here

[geoand]

OK thanks.

If CI has passed on your fork, then go ahead and take the PR out of draft.
Furthermore, we'll need some documentation bits

[geoand]

Also, don't forget to squash the commits once the review is done (I can't promise you a timeline for this ufortunately)

[essobedo]

Also, don't forget to squash the commits once the review is done (I can't promise you a timeline for this ufortunately)

@geoand ok, no problem, meanwhile I squashed my commits

[essobedo]

FYI the test that fails on the CI, doesn't fail on my local machine, maybe it is known as a random failure?

[geoand]

Most likely it's a flaky test, I'll rerun it

[geoand]

This is great work, thanks!

Once the doc issues I suggested are addressed and CI finishes, let's merge

[geoand]

And of course we'll need the commits squashed :)

[geoand]

Just to satisfy my curiousity, how do you plan to use this feature?

[essobedo]

And of course we'll need the commits squashed :)

@geoand done

[essobedo]

Just to satisfy my curiousity, how do you plan to use this feature?

@geoand Good question 😄 . This is actually one part of my need, my second need (next contribution if accepted by you, the Quarkus team?) is to be able to manage several artifacts with different classifiers in the same module with the maven plugin, pretty much like when you propose the same artifact but for different target JDK versions. The idea behind is to have the same module in which you have everything mixed but annotated with build time conditions and build your final artifact with different build profiles. You would then be able to create an artifact for 'dev', 'stating' and 'prod' from the same module with one single maven command instead of launching the build command for each profile.

[geoand]

Understood, thanks for the info