Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define the build profile at maven plugin level #15356

Merged

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Feb 27, 2021

fixes #13341

Motivation

We would like to have the ability to define the build profile directly in the configuration of the plugin or via a project property.

Modifications:

  • Checks if the project property quarkus.profile has been set and if so uses this value as build profile if and only if it has not already been set using the corresponding system property or environment variable.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Feb 27, 2021
@aloubyansky
Copy link
Member

We've been avoiding adding mojo parameters that duplicate application properties. E.g. the uberJar mojo parameter has recently been removed. Which I personally wasn't sure about but that was the decision and we should probably stick to it for other config options as well. Unless the users start pushing hard for it.
In this specific case though, I guess you could remove the parameter and simply look for the project property with that name. I think it'd be an acceptable compromise. WDYT? And thanks for another contribution @essobedo

@essobedo essobedo force-pushed the 13341/add-build-profile-to-maven-plugin branch from 8625f20 to ee5d59c Compare March 1, 2021 07:36
@essobedo
Copy link
Contributor Author

essobedo commented Mar 1, 2021

@aloubyansky Hi I was not aware of this rule, indeed it makes sense to remove it, so here is a new version with only the support of project property

@essobedo essobedo force-pushed the 13341/add-build-profile-to-maven-plugin branch from ee5d59c to 161e5f7 Compare March 1, 2021 07:46
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @essobedo

@gsmet gsmet merged commit be45a1d into quarkusio:master Mar 1, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 1, 2021
@gsmet
Copy link
Member

gsmet commented Mar 1, 2021

Merged, thanks!

@essobedo essobedo deleted the 13341/add-build-profile-to-maven-plugin branch March 2, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven property quarkus.profile should be picked up by quarkus-maven-plugin
3 participants