Make sure quarkus-bom platform does not force its BOM over other platforms found in the project #15444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther platforms found in the project
quarkus-bot
bot
added
area/devtools
|
@quarkusio/devtools could someone from devtools review this? AFAIK, we need to backport it to 1.11 so better have a close look at this. |
|
@aloubyansky how to reproduce this scenario? |
|
I couldn't reproduce this scenario using 1.12.1.Final or 1.11.5.Final. |
gastaldi
reviewed
Mar 4, 2021
devtools/gradle/src/main/java/io/quarkus/gradle/tasks/QuarkusPlatformTask.java
Show resolved
Hide resolved
gastaldi
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is about properly merging platform descriptors found in the project for the devtools.
Normally, it's a straightforward exercise, i.e. simply collect dependencies that match a pre-defined artifactId suffix.
The ordering of the descriptors in our platform BOMs might not be consistent across different builds though.
So this code is doing rough filtering to make sure the base platform (quarkus-bom) descriptor
does not appear to be forcing its BOM over the other platforms found in the project.
Luckily, though, this code is going to be replaced in the next version using the new extension catalog API.