ArC - support CDI decorators #16010
Merged
ArC - support CDI decorators #16010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Mar 25, 2021
mkouba
commented
- resolves Support CDI decorators #15490
Ladicek
approved these changes
Mar 30, 2021
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanGenerator.java
Outdated
Show resolved
Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanInfo.java
Show resolved
Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Decorators.java
Show resolved
Hide resolved
...endent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/DecoratorGenerator.java
Outdated
Show resolved
Hide resolved
manovotn
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
I reviewed and tried this last week and since there were no major changes in the meantime, I am still good with it :-)
Just one question - do you plan to address documentation in a separate PR? Since we not state that decorators are unsupported.
That's a good point. I should move decorators to the list of supported features ;-) |
manovotn
reviewed
Mar 30, 2021
- resolves quarkusio#15490 Update independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanGenerator.java Co-authored-by: Ladislav Thon <[email protected]> Update docs/src/main/asciidoc/cdi.adoc Co-authored-by: Matej Novotny <[email protected]>
|
Wow, awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.