Update OIDC client code to retry in case of the connection errors and have OIDC starting without the complete config #16060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cescoffier
requested changes
Mar 28, 2021
extensions/oidc-client/runtime/src/main/java/io/quarkus/oidc/client/runtime/OidcClientImpl.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/TenantConfigContext.java
Show resolved
Hide resolved
… have OIDC starting without the complete config
sberyozkin
force-pushed
the
oidc_request_retry
branch
from
a990c02 to
7a630dd
Compare
|
@cescoffier Did a minor update to use |
cescoffier
approved these changes
Mar 29, 2021
|
@cescoffier thanks, I'll wait till tomorrow and see if @pedroigor has some comments as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15599.
Fixes #15933.
Fixes #16061.
This PR:
connection droppedexceptionsquarkus-oidccan start without any static configuration without even having to settenant-enabled=false- it has been a blocker for the dev mode (orcode.quarkus.io) for a while.(I had to add a
TenantConfigContextreadyflag - as recovering from the exception withnulldoes not work - but it can be useful to log at the request time that the tenant with a specific id is not initialized)CC @cescoffier