Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include kubernetes-client config in all-config page #16086

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 29, 2021

Fixes: #16052

@geoand geoand requested a review from aloubyansky March 29, 2021 09:05
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Mar 29, 2021
@geoand
Copy link
Contributor Author

geoand commented Mar 29, 2021

I know that these changes are needed to make the docs work, but I wasn't able to verify that the kubernetes client config actually ends up in the generated docs because I was not able to verify the same for configuration that already does exist in that page (for example quarkus.container-image.* items).

@gsmet any pointers here would be appreciated :)

@aloubyansky
Copy link
Member

Did have the wrong artifactId all over the place?

@geoand
Copy link
Contributor Author

geoand commented Mar 29, 2021

The problem with the artifact name (and the reason I changed it) was that it was causing a NPE in the GeneratePlatformDescriptorJsonMojo (I think anyway - there were various failures on this artifact I had to work through to get this working).
So I changed all instances of that deployment artifact name

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Mar 29, 2021
gsmet
gsmet previously requested changes Mar 29, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a small typo.

I don't have the time to check what's happening with the docs at the moment. Maybe @machi1990 could have a look? If not, I'll have a look later this week.

@geoand
Copy link
Contributor Author

geoand commented Mar 29, 2021

I don't have the time to check what's happening with the docs at the moment. Maybe @machi1990 could have a look? If not, I'll have a look later this week.

I will merge this in the the meantime as it's necessary anyway

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 29, 2021
@machi1990
Copy link
Member

I know that these changes are needed to make the docs work, but I wasn't able to verify that the kubernetes client config actually ends up in the generated docs because I was not able to verify the same for configuration that already does exist in that page (for example quarkus.container-image.* items).

@gsmet any pointers here would be appreciated :)

I can do the verification if this is still needed @geoand .

@geoand
Copy link
Contributor Author

geoand commented Mar 29, 2021

I can do the verification if this is still needed @geoand .

Thanks. Once I merge it, feel free to check :)

@machi1990
Copy link
Member

I can do the verification if this is still needed @geoand .

Thanks. Once I merge it, feel free to check :)

LGTM, I compiled the docs with mvn clean install -DskipTests -DskipITs and then cat target/asciidoc/generated/config/quarkus-all-config.adoc | grep "kubernetes-client" showed entries like

a|icon:lock[title=Fixed at build time] [[quarkus-kubernetes-client-internal_quarkus.kubernetes-client.trust-certs]]`link:#quarkus-kubernetes-client-internal_quarkus.kubernetes-client.trust-certs[quarkus.kubernetes-client.trust-certs]`
a|icon:lock[title=Fixed at build time] [[quarkus-kubernetes-client-internal_quarkus.kubernetes-client.master-url]]`link:#quarkus-kubernetes-client-internal_quarkus.kubernetes-client.master-url[quarkus.kubernetes-client.master-url]`
a|icon:lock[title=Fixed at build time] [[quarkus-kubernetes-client-internal_quarkus.kubernetes-client.namespace]]`link:#quarkus-kubernetes-client-internal_quarkus.kubernetes-client.namespace[quarkus.kubernetes-client.namespace]`

@geoand
Copy link
Contributor Author

geoand commented Mar 29, 2021

Thanks!

@geoand geoand merged commit e9f5c91 into quarkusio:main Mar 29, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 29, 2021
@geoand geoand deleted the #16052 branch March 29, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus "all config" guide is missing kubernetes-client config
4 participants