-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include kubernetes-client config in all-config page #16086
Conversation
I know that these changes are needed to make the docs work, but I wasn't able to verify that the kubernetes client config actually ends up in the generated docs because I was not able to verify the same for configuration that already does exist in that page (for example @gsmet any pointers here would be appreciated :) |
Did have the wrong artifactId all over the place? |
The problem with the artifact name (and the reason I changed it) was that it was causing a NPE in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a small typo.
I don't have the time to check what's happening with the docs at the moment. Maybe @machi1990 could have a look? If not, I'll have a look later this week.
This is needed in order to make Quarkus generate various metadata files. Fixes: quarkusio#16052
I will merge this in the the meantime as it's necessary anyway |
I can do the verification if this is still needed @geoand . |
Thanks. Once I merge it, feel free to check :) |
LGTM, I compiled the docs with
|
Thanks! |
Fixes: #16052