Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micrometer: Simplify Vertx HTTP binder init; http settings in dev mode #16164

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Micrometer: Simplify Vertx HTTP binder init; http settings in dev mode #16164

merged 1 commit into from
Apr 1, 2021

Conversation

ebullient
Copy link
Member

@ebullient ebullient commented Mar 31, 2021 •
edited
Loading

Resolves #16130

@ebullient ebullient marked this pull request as ready for review April 1, 2021 02:14
@ebullient ebullient changed the title Remove some CDI-ness. Fix dev mode Micrometer: Simplify Vertx HTTP binder init; http settings in dev mode Apr 1, 2021
@ebullient ebullient merged commit 45dc3fe into quarkusio:main Apr 1, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 1, 2021
@ebullient ebullient deleted the micrometer-cdi branch April 1, 2021 04:59
@ebullient ebullient mentioned this pull request Apr 6, 2021
Closed
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 7, 2021
@ebullient ebullient mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/metrics
Projects
None yet
Milestone
1.13.1.Final
Development

Successfully merging this pull request may close these issues.

Micrometer Vert.x Binder Locks Shutdown on devmode
3 participants
@ebullient @stuartwdouglas @gsmet