Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest Client Reactive: detect blocking the event loop #16181

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Rest Client Reactive: detect blocking the event loop #16181

merged 1 commit into from
Apr 2, 2021

Conversation

michalszynkiewicz
Copy link
Member

@michalszynkiewicz michalszynkiewicz commented Apr 1, 2021 •
edited
Loading

very basic, run-time check

@michalszynkiewicz michalszynkiewicz requested a review from geoand April 1, 2021 13:11
@quarkus-bot quarkus-bot bot added the area/rest label Apr 1, 2021
@michalszynkiewicz michalszynkiewicz changed the title Rest Client Reactive: block event loop detection Rest Client Reactive: detect blocking the event loop Apr 1, 2021
gsmet
gsmet reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted some case issues, feel free to ignore :).

@geoand should this be backported?

@geoand
Copy link
Contributor

geoand commented Apr 1, 2021

Yeah, this is really useful so we should backport it

@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-reactive-lock-detection branch from e01f151 to e435be8 Compare April 1, 2021 18:21
@michalszynkiewicz michalszynkiewicz added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 1, 2021
@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-reactive-lock-detection branch from e435be8 to aeb3a3c Compare April 1, 2021 21:42
@famod famod merged commit c449020 into quarkusio:main Apr 2, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 2, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 2, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
1.13.1.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@michalszynkiewicz @geoand @gsmet @famod