Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST Client Reactive cleanup #16186

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 1, 2021

  • Rename jaxrs-client to jaxrs-client-reactive
  • Follow our package naming conventions
  • Add missing quarkus-extension.yaml
  • Move misplaced quarkus-extension.yaml
  • Move non-API classes to runtime subpackage
  • Produce features for all the extensions
  • Rename some classes for more consistency
  • Rename the config to rest-client-reactive as we don't want conflicts with configuration between the extensions

see https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Reactive.20REST.20Client for general context

We can discuss the specific changes but I thought it was better really working on a PR to see exactly what needed fixing.

Creating as draft for now to get CI running in my fork.

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/rest labels Apr 1, 2021
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@gsmet gsmet force-pushed the rest-client-reactive branch from a970340 to 6f36d6f Compare April 1, 2021 16:05
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Apr 1, 2021
- Rename jaxrs-client to jaxrs-client-reactive
- Follow our package naming conventions
- Add missing quarkus-extension.yaml
- Move misplaced quarkus-extension.yaml
- Move non-API classes to runtime subpackage
- Produce features for all the extensions
- Rename some classes for more consistency
@gsmet
Copy link
Member Author

gsmet commented Apr 2, 2021

The TCK Tests will fail because of quarkusio/resteasy-reactive-testsuite#1 but I checked both the MP REST Client Reactive TCK and the RESTEasy Reactive test suite are passing locally.

@gsmet gsmet merged commit d3ecfb2 into quarkusio:main Apr 2, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 2, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/rest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants