Update OIDC to accept all RS and ES algorithms #16287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sberyozkin for the quick PR. User would be me. I assume more are running with ES instead of RS. |
middagj
approved these changes
Apr 6, 2021
|
@middagj thanks, indeed ES algorithms are becoming more mainstream :-). Faster too. But I guess |
pedroigor
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively restores what was available with Vert.x Auth - where all the asymmetric algorithms are accepted - as a user has reported a problem with migrating to
1.13.0.Finalas their Keycloak test framework uses not onlyRS256.In a separate PR I'll add a configuration property for the users be able to restrict to a very specific algorithm which is the best practice (supporting N algorithms in a single deployment is not ideal) - it will also mirror the smallrye-jwt approach