Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly wait for the broker to be running before executing the test #16305

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

cescoffier
Copy link
Member

Also, increase the range between used ports, as a broker may register multiple ports.

Unfortunately, this commit does not fix the conflicting broker ids because Debezium overrides the broker id and set 1 to all of them.

I'm not very happy with the reflection calls, but let's see if it stabilize the CI. If so, we can investigate another approach exposing the Kafka servers directly.

Also, increase the range between used ports, as a broker may register multiple ports.

Unfortunately, this commit does not fix the conflicting broker ids because Debezium overrides the broker id and set 1 to all of them.
@cescoffier cescoffier requested a review from gsmet April 7, 2021 06:25
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least, the build passed so it's encouraging! Thanks!

@gsmet gsmet merged commit 9443e30 into quarkusio:main Apr 7, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 7, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 7, 2021
@cescoffier cescoffier deleted the fix-kafka-broker-id branch August 1, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants