Fix race condition on reactive client with streaming and SSE responses

[geoand]

Fixes: #16227

[geoand]

I used JUnit's @RepeatedTest(1000) (and even then did multiple runs) locally to ensure that these tests are not flaky any more with this fix

[FroMage]

So hold on, the fix is which part? Is it a double call to complete() or a double call to close(true)? Both?

IIRC closeHandler was called when the server dropped the connection without ending/responding it. I'm not sure we have tests in place for this case (not sure how we could).

[geoand]

The PR fixes 2 different cases - one for streaming chunks and one for SSE (which correspond to the 2 re-enabled tests).

In both cases it could happen that the closeHandler of the connection was being called before the handler for the items

[FroMage]

Oh, close before handler for items. Damn. Huh. Oh well, I guess we can fix this and wait until any bug related to connection dying appear later. But, then please add a comment in both cases to explain why there's no closeHandler pointing to this issue because we'll never remember to not add it ;)

[geoand]

Will do

[geoand]

PR updated with the request comment

[FroMage]

Great, thanks!

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a236231

Status	Name	Step	Test failures	Logs	Raw logs
❓	Devtools Tests - JDK ${{ matrix.java.name }}		⚠️ Check →
❓	Devtools Tests - JDK 11 Windows		⚠️ Check →
❓	Gradle Tests - JDK 11 ${{ matrix.os.family }}		⚠️ Check →
✖	Initial JDK 11 Build	Build	⚠️ Check →	Logs	Raw logs
❓	JVM Tests - JDK ${{ matrix.java.name }}		⚠️ Check →
❓	JVM Tests - JDK 11 Windows		⚠️ Check →
❓	Maven Tests - JDK ${{ matrix.java.name }}		⚠️ Check →
❓	Maven Tests - JDK 11 Windows		⚠️ Check →
❓	MicroProfile TCKs Tests		⚠️ Check →
❓	Native Tests - ${{ matrix.category }}		⚠️ Check →
❓	Native Tests - Windows - ${{ matrix.category }}		⚠️ Check →

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d634926

Status	Name	Step	Test failures	Logs	Raw logs
❓	Devtools Tests - JDK ${{ matrix.java.name }}		⚠️ Check →
❓	Devtools Tests - JDK 11 Windows		⚠️ Check →
❓	Gradle Tests - JDK 11 ${{ matrix.os.family }}		⚠️ Check →
✖	Initial JDK 11 Build	Build	⚠️ Check →	Logs	Raw logs
❓	JVM Tests - JDK ${{ matrix.java.name }}		⚠️ Check →
❓	JVM Tests - JDK 11 Windows		⚠️ Check →
❓	Maven Tests - JDK ${{ matrix.java.name }}		⚠️ Check →
❓	Maven Tests - JDK 11 Windows		⚠️ Check →
❓	MicroProfile TCKs Tests		⚠️ Check →
❓	Native Tests - ${{ matrix.category }}		⚠️ Check →
❓	Native Tests - Windows - ${{ matrix.category }}		⚠️ Check →

[cescoffier]

But worried about closing.

[geoand]

Yeah, we'll have to see...

[gsmet]

Rebased to get the latest CI fixes.

[quarkus-bot]

Milestone is already set for some of the items:

• Issue Investigate io.quarkus.resteasy.reactive.server.test.stream.StreamTestCase#testClientStreaming #16227

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.