Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest Client Reactive guide #16441

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

michalszynkiewicz
Copy link
Member

@michalszynkiewicz michalszynkiewicz commented Apr 12, 2021

This is mostly a copy of the classic Rest Client guide

Quickstart PR: quarkusio/quarkus-quickstarts#829

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I added a bunch of comments that I think should add a little more clarity.

Furthermore, I think it would be good to have a link from the legacy REST Client documentation to the new one (which an explanation on when the new one should be prefered)

@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-reactive-guide branch from 027f7da to 9c1c0ff Compare April 12, 2021 13:12
@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-reactive-guide branch from 9c1c0ff to 24fc21a Compare April 12, 2021 17:49
@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-reactive-guide branch from 24fc21a to e71cfaa Compare April 12, 2021 20:11
@michalszynkiewicz
Copy link
Member Author

the failing job fails with

Error:  Failed to execute goal on project quarkus-hibernate-reactive: Could not resolve dependencies for project io.quarkus:quarkus-hibernate-reactive:jar:999-SNAPSHOT: Failed to collect dependencies at org.hibernate.reactive:hibernate-reactive-core:jar:1.0.0.CR1.Vertx4: Failed to read artifact descriptor for org.hibernate.reactive:hibernate-reactive-core:jar:1.0.0.CR1.Vertx4: Could not transfer artifact org.hibernate.reactive:hibernate-reactive-core:pom:1.0.0.CR1.Vertx4 from/to hibernate-reactive-beta (https://dl.bintray.com/davided/artifacts/): Authorization failed for https://dl.bintray.com/davided/artifacts/org/hibernate/reactive/hibernate-reactive-core/1.0.0.CR1.Vertx4/hibernate-reactive-core-1.0.0.CR1.Vertx4.pom 403 Forbidden -> [Help 1]

I don't know what to think about it :D

@geoand
Copy link
Contributor

geoand commented Apr 12, 2021

See zulip chat.

Unfortunately things are in a bad state for the time being...

@geoand
Copy link
Contributor

geoand commented Apr 13, 2021

Time to rebase - main has been updated to not encounter that issue :)

@michalszynkiewicz michalszynkiewicz force-pushed the rest-client-reactive-guide branch from e71cfaa to 0da6ae6 Compare April 13, 2021 07:38
@geoand geoand merged commit af74476 into quarkusio:main Apr 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants