Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Apicurio Registry 2.x Avro library #16473

Merged
merged 3 commits into from
Apr 25, 2021

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Apr 13, 2021

No description provided.

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 13, 2021

Draft because Apicurio Registry 2.x hasn't been released yet.

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 13, 2021

And also I need to add a test :-)

gsmet
gsmet previously requested changes Apr 13, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a small comment, please dismiss when fixed

@Ladicek Ladicek force-pushed the apicurio-registry-2.x branch from ad64760 to 3f88ff4 Compare April 13, 2021 13:05
@Ladicek Ladicek force-pushed the apicurio-registry-2.x branch from 3f88ff4 to 085cb83 Compare April 20, 2021 15:22
@quarkus-bot quarkus-bot bot added area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kafka-streams labels Apr 20, 2021
@Ladicek Ladicek marked this pull request as ready for review April 20, 2021 15:25
@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 20, 2021

Ready for review, as Apicurio Registry 2.0.0.Final was released.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 085cb83

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
🚫 Initial JDK 11 Build
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs
🚫 Devtools Tests - JDK ${{ matrix.java.name }}
🚫 Devtools Tests - JDK 11 Windows
🚫 Gradle Tests - JDK 11 ${{ matrix.os.family }}
🚫 JVM Tests - JDK ${{ matrix.java.name }}
🚫 JVM Tests - JDK 11 Windows
🚫 Maven Tests - JDK ${{ matrix.java.name }}
🚫 Maven Tests - JDK 11 Windows
🚫 MicroProfile TCKs Tests
🚫 Native Tests - ${{ matrix.category }}
Native Tests - Read JSON matrix ⚠️ Check → Logs Raw logs
🚫 Native Tests - Windows - ${{ matrix.category }}

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 085cb83

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka-avro-apicurio2

io.quarkus.it.kafka.KafkaAvroTest.testApicurioAvroProducer - More details - Source on GitHub

io.quarkus.it.kafka.KafkaAvroTest.testApicurioAvroConsumer line 60 - More details - Source on GitHub

io.quarkus.it.kafka.KafkaAvroTest.testConfluentAvroProducer - More details - Source on GitHub

io.quarkus.it.kafka.KafkaAvroTest.testConfluentAvroConsumer line 41 - More details - Source on GitHub


⚙️ JVM Tests - JDK 15 #

📦 integration-tests/kafka-avro-apicurio2

io.quarkus.it.kafka.KafkaAvroTest.testApicurioAvroProducer - More details - Source on GitHub

io.quarkus.it.kafka.KafkaAvroTest.testApicurioAvroConsumer line 60 - More details - Source on GitHub

io.quarkus.it.kafka.KafkaAvroTest.testConfluentAvroProducer - More details - Source on GitHub

io.quarkus.it.kafka.KafkaAvroTest.testConfluentAvroConsumer line 41 - More details - Source on GitHub

@Ladicek Ladicek force-pushed the apicurio-registry-2.x branch from 085cb83 to a5bc92d Compare April 21, 2021 13:59
@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 21, 2021

To fix the test failure, I rebased my branch and added https://github.com/quarkusio/quarkus/pull/16251/files#diff-6d16e1bd2cec46a1c2d8f00ec4f3476b7554df6379ac769a0492f8aad9f69911 to the new kafka-avro-apicurio2 test suite module.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 21, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a5bc92d

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 15 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 15 #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.UriTagCorsTest.testCORSPreflightRequest line 101 - More details - Source on GitHub

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 22, 2021

That looks quite unrelated.

@Ladicek Ladicek requested a review from gsmet April 22, 2021 09:16
@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 22, 2021

Sorry, I don't know how to properly "dismiss" the request for change :-)

@Ladicek Ladicek force-pushed the apicurio-registry-2.x branch from a5bc92d to d8c7e17 Compare April 22, 2021 09:51
@Ladicek Ladicek dismissed gsmet’s stale review April 22, 2021 09:52

addressed the request

@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 22, 2021

Ha, now I know how to dismiss the request :-) Haha, sorry for the noise!

I also rebased and re-pushed, maybe the unrelated flaky test will pass this time.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building d8c7e17

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/jdbc/jdbc-mysql/deployment

io.quarkus.jdbc.mysql.deployment.DevServicesMySQLDatasourceTestCase.testDatasource - More details - Source on GitHub

@Ladicek Ladicek force-pushed the apicurio-registry-2.x branch from d8c7e17 to 6691294 Compare April 23, 2021 06:48
@Ladicek
Copy link
Contributor Author

Ladicek commented Apr 23, 2021

Rebased, as #16746 might have fixed the MySQL issue.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kafka area/kafka-streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants