-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Apicurio Registry 2.x Avro library #16473
Conversation
Draft because Apicurio Registry 2.x hasn't been released yet. |
And also I need to add a test :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a small comment, please dismiss when fixed
...kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/KafkaProcessor.java
Outdated
Show resolved
Hide resolved
ad64760
to
3f88ff4
Compare
3f88ff4
to
085cb83
Compare
Ready for review, as Apicurio Registry 2.0.0.Final was released. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 085cb83
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 085cb83
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/kafka-avro-apicurio2✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 15 #📦 integration-tests/kafka-avro-apicurio2✖ ✖ ✖ ✖ |
085cb83
to
a5bc92d
Compare
To fix the test failure, I rebased my branch and added https://github.com/quarkusio/quarkus/pull/16251/files#diff-6d16e1bd2cec46a1c2d8f00ec4f3476b7554df6379ac769a0492f8aad9f69911 to the new |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building a5bc92d
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 15 #📦 extensions/micrometer/deployment✖ |
That looks quite unrelated. |
Sorry, I don't know how to properly "dismiss" the request for change :-) |
a5bc92d
to
d8c7e17
Compare
Ha, now I know how to dismiss the request :-) Haha, sorry for the noise! I also rebased and re-pushed, maybe the unrelated flaky test will pass this time. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d8c7e17
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/jdbc/jdbc-mysql/deployment✖ |
d8c7e17
to
6691294
Compare
Rebased, as #16746 might have fixed the MySQL issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
No description provided.