Enable AddExtensionIT.testAddExtensionWithASingleExtensionToSubmodule #16564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Apr 16, 2021
aloubyansky
reviewed
Apr 16, 2021
| @@ -61,7 +61,8 @@ void testAddExtensionWithASingleExtensionToSubmodule() throws MavenInvocationExc | |||
| expected.setArtifactId(VERTX_ARTIFACT_ID); | |||
| assertThat(contains(model.getDependencies(), expected)).isTrue(); | |||
|
|
|||
| assertThat(model.getDependencyManagement().getDependencies()).isEmpty(); | |||
| assertThat(Optional.ofNullable(model.getDependencyManagement()) | |||
| .map(DependencyManagement::getDependencies).orElse(Collections.emptyList())).isEmpty(); | |||
There was a problem hiding this comment.
How about model.getDependencyManagement() == null ? Collections.emptyList() : model.getDependencyManagement().getDependencies();
There was a problem hiding this comment.
Guillaume merged it already. 😉
I'm a bit of a DRY fanatic, so I personally don't like the redudant calls that come with that pattern.
There was a problem hiding this comment.
Doesn't your code result in more calls? And, I guess, it's a lot more JVM "work" for the same result.
There was a problem hiding this comment.
Yes, more calls and thus a bit more work, but no repetition.
It's a matter of personal preference, YMMV.
If your version is more in line with what is usually being used in Quarkus then I'll try to remember that next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14164 was fixed via #16290
/cc @aloubyansky