-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the ability to mock @Singleton beans #16574
Conversation
e46b0b7
to
b12adf3
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building e46b0b7
|
b12adf3
to
f3c9f75
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building b12adf3
|
@mkouba WDYT about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's an opt-in feature I think it's OK, if we document it well...
test-framework/junit5-mockito/src/main/java/io/quarkus/test/junit/mockito/InjectMock.java
Outdated
Show resolved
Hide resolved
test-framework/junit5-mockito/src/main/java/io/quarkus/test/junit/mockito/InjectMock.java
Outdated
Show resolved
Hide resolved
This is done by giving users the ability to configure whether or not Quarkus can change the scope of the bean, so Quarkus can then change the scope from @singleton to @ApplicationScoped
f3c9f75
to
a337455
Compare
@mkouba I applied your suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This is done by giving users the ability to configure
whether or not Quarkus can change the scope of the bean,
so Quarkus can then change the scope from
@Singleton
to@ApplicationScoped