Take advantage of codestarts to allow creating a quarkus application as a maven module (WIP) #17170

cristian-com · 2021-05-12T10:44:42Z

Fixes: #12936

ia3andy

Thanks, I added a few comment.

devtools/maven/src/main/java/io/quarkus/maven/CreateProjectMojo.java

.../base-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/base/pom.tpl.qute.xml

...ols-common/src/main/java/io/quarkus/devtools/codestarts/quarkus/QuarkusCodestartCatalog.java

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

ia3andy · 2021-05-31T12:54:13Z

@cristian-com could you rebase from main?

cristian-com

@ia3andy I'm unsure now if this applies for CLI, I will add it if that makes sense.

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

quarkus-bot · 2021-06-29T07:48:24Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `d5e18c4`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-06-29T07:58:28Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `a6c2629`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-06-29T08:02:28Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `ed22adc`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

...projects/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/CreateProject.java

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

ebullient · 2021-06-29T13:23:52Z

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

@@ -137,11 +182,12 @@ public QuarkusCommandOutcome execute(QuarkusCommandInvocation invocation) throws
                    .example(invocation.getValue(EXAMPLE))
                    .noCode(invocation.getValue(NO_CODE, false))
                    .addCodestarts(invocation.getValue(EXTRA_CODESTARTS, Collections.emptySet()))
-                    .noBuildToolWrapper(invocation.getValue(NO_BUILDTOOL_WRAPPER, false))
+                    .noBuildToolWrapper(invocation.getValue(NO_BUILDTOOL_WRAPPER, parent != null))


I don't know that this is the best assumption, though I understand why you're doing it this way. We have a separate issue open for detecting wrappers that would interfere here.

This based on the issue description #12936 (comment)
If it is not applicable I'll leave it as false

@ebullient why would it interfere since we still use the invocation value? Cristian change is only affecting the default behavior..

@cristian-com after giving it a try, it seems not be working since this default is never* used.

* because we have another default overriding it in the caller..

Maybe we shouldn't pass any default in the callers when not expressly set by the user

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

.../base-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/base/pom.tpl.qute.xml

maxandersen · 2021-07-06T06:57:34Z

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

@@ -205,4 +256,53 @@ public QuarkusCommandOutcome execute(QuarkusCommandInvocation invocation) throws
        }
        return ElementCatalogBuilder.getMembersForElements(ec, eKeys);
    }
+
+    private void addModuleToParentPom(QuarkusCommandInvocation invocation, Model parent,


just a thought - parent pom is not necessarily the same as the aggregator pom.
you can easiliy have a parent that is not in your parent directory and in parent directory is only an aggregator.

I'm wondering if it would be worth printing a info or warning to users in case of the parent dir found pom has but no build sections then most likely user want to control if we generated the right parent pom....

technically maybe the only thing we should do is to add our selves to the aggregator pom ?

We are adding ourselves to the aggregator pom. A different question I think would be if we always want to do so in that case.

ia3andy

Looking good beside a few comments here and there.

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

ia3andy · 2021-07-07T13:12:39Z

...-common/src/main/java/io/quarkus/devtools/commands/handlers/CreateProjectCommandHandler.java

@@ -137,11 +182,12 @@ public QuarkusCommandOutcome execute(QuarkusCommandInvocation invocation) throws
                    .example(invocation.getValue(EXAMPLE))
                    .noCode(invocation.getValue(NO_CODE, false))
                    .addCodestarts(invocation.getValue(EXTRA_CODESTARTS, Collections.emptySet()))
-                    .noBuildToolWrapper(invocation.getValue(NO_BUILDTOOL_WRAPPER, false))
+                    .noBuildToolWrapper(invocation.getValue(NO_BUILDTOOL_WRAPPER, parent != null))


@cristian-com after giving it a try, it seems not be working since this default is never* used.

* because we have another default overriding it in the caller..

Maybe we shouldn't pass any default in the callers when not expressly set by the user

quarkus-bot · 2021-07-07T13:21:21Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `f97d60d`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-07T18:33:44Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `38ecb74`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Devtools Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs
✖	Maven Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	Maven Tests - JDK 11 Windows	`Build`	Test failures	Logs	Raw logs

Test Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.testRegexpMatches line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.testPartialMatches line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addExtensionWithGAV line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.doesNotAddExtensionsWhenMultipleMatchWithOneKeyword line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addDuplicatedExtensionUsingGAV line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.testVertx line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addExtensionWithGroupIdAndArtifactId line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addExistingAndMissingExtensionsWillFailForBoth line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.testVertxWithDot line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addExtensionTwiceInOneBatch line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.doNotAddExtensionWhenMultipleMatchWithMultipleKeywords line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addMissingExtension line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addExtensionTwiceInTwoBatches line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddGradleExtensionsTest.addSomeValidExtensions line 24 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.testRegexpMatches line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.testPartialMatches line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addExtensionWithGAV line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.doesNotAddExtensionsWhenMultipleMatchWithOneKeyword line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addDuplicatedExtensionUsingGAV line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.testVertx line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addExtensionWithGroupIdAndArtifactId line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addExistingAndMissingExtensionsWillFailForBoth line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.testVertxWithDot line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addExtensionTwiceInOneBatch line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.doNotAddExtensionWhenMultipleMatchWithMultipleKeywords line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addMissingExtension line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addExtensionTwiceInTwoBatches line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.AddMavenExtensionsTest.addSomeValidExtensions line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectPlatformMetadataTest.createGradleKotlin line 62 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectPlatformMetadataTest.create line 37 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectPlatformMetadataTest.createGradle line 52 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectTest.createOnTopOfExisting line 206 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectTest.createSpringWeb line 87 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectTest.createRESTEasyAndSpringWeb line 115 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectTest.createMultipleTimes line 233 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectTest.createGradle line 146 - Source on GitHub

✖ io.quarkus.devtools.commands.CreateProjectTest.createRESTEasy line 48 - Source on GitHub

✖ io.quarkus.devtools.commands.ListExtensionsTest.listWithBomExtensionWithSpaces line 58 - Source on GitHub

✖ io.quarkus.devtools.commands.ListExtensionsTest.searchRest line 154 - Source on GitHub

✖ io.quarkus.devtools.commands.ListExtensionsTest.listWithoutBom line 73 - Source on GitHub

✖ io.quarkus.devtools.commands.ListExtensionsTest.listWithBom line 40 - Source on GitHub

✖ io.quarkus.devtools.commands.ListExtensionsTest.searchUnexpected line 135 - Source on GitHub

✖ io.quarkus.devtools.commands.RemoveGradleExtensionsTest.testRegexpMatches line 18 - Source on GitHub

✖ io.quarkus.devtools.commands.RemoveGradleExtensionsTest.testPartialMatches line 18 - Source on GitHub

✖ io.quarkus.devtools.commands.RemoveGradleExtensionsTest.removeSomeValidExtensions line 18 - Source on GitHub

✖ io.quarkus.devtools.commands.RemoveMavenExtensionsTest.testRegexpMatches line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.RemoveMavenExtensionsTest.testPartialMatches line 19 - Source on GitHub

✖ io.quarkus.devtools.commands.RemoveMavenExtensionsTest.removeSomeValidExtensions line 19 - Source on GitHub

✖ io.quarkus.devtools.project.compress.QuarkusProjectCompressTest.createZipWithParentFolder line 61 - Source on GitHub

✖ io.quarkus.devtools.project.compress.QuarkusProjectCompressTest.createZip line 40 - Source on GitHub

⚙️ Devtools Tests - JDK 11 Windows #