Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump junit-jupiter from 5.7.1 to 5.7.2 #17273

Merged
merged 1 commit into from
May 17, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 17, 2021

Bumps junit-jupiter from 5.7.1 to 5.7.2.

Release notes

Sourced from junit-jupiter's releases.

JUnit 5.7.2 = Platform 1.7.2 + Jupiter 5.7.2 + Vintage 5.7.2

See Release Notes.

Commits
  • 0ba600e Move #2423 to 5.7.2
  • e6d74ab Acquire global read lock in presence of other exclusive resources
  • 267ce62 Add Stalebot configuration
  • 05414dc Upgradle to 7.0.1
  • 8d9ef80 Update spring-nohttp plugin
  • 4e98f55 Hard-wrap at 90 chars and add indentation
  • 6359e51 Add Provide-Capability OSGi header to engine bundles
  • a02c62a Move entry to 5.7.2 release notes
  • 4f206d3 Update shadow plugin
  • 81e6b00 Update Kotlin plugin
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @gsmet.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label May 17, 2021
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels May 17, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 17, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2021

Failing Jobs - Building d15748f

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/elytron-undertow

io.quarkus.it.undertow.elytron.BaseAuthTest.testPost line 27 - More details - Source on GitHub

@famod
Copy link
Member

famod commented May 17, 2021

Test failure root cause is not related:

2021-05-17 12:01:42,296 WARNING [org.jun.jup.eng.dis.MethodSelectorResolver] (main) Possible configuration error: method [void io.quarkus.it.undertow.elytron.BaseAuthRestTest.testPost()] resulted in multiple TestDescriptors [org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor, org.junit.jupiter.engine.descriptor.TestTemplateTestDescriptor]. This is typically the result of annotating a method with multiple competing annotations such as @Test, @RepeatedTest, @ParameterizedTest, @TestFactory, etc.
2021-05-17 12:01:42,335 WARNING [org.jun.jup.eng.dis.MethodSelectorResolver] (main) Possible configuration error: method [void io.quarkus.it.undertow.elytron.BaseAuthRestTest.testPost()] resulted in multiple TestDescriptors [org.junit.jupiter.engine.descriptor.TestTemplateTestDescriptor, org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor]. This is typically the result of annotating a method with multiple competing annotations such as @Test, @RepeatedTest, @ParameterizedTest, @TestFactory, etc.
2021-05-17 12:01:47,826 INFO  [io.qua.ely.sec.pro.dep.ElytronPropertiesProcessor] (build-16) Configuring from MPRealmConfig
2021-05-17 12:01:49,370 WARN  [io.und.servlet] (main) UT015020: Path /annotation-secure is secured for some HTTP methods, however it is not secured for [PUT]
2021-05-17 12:01:49,370 WARN  [io.und.servlet] (main) UT015020: Path /secure/* is secured for some HTTP methods, however it is not secured for [TRACE, HEAD, DELETE, CONNECT, OPTIONS, PUT]
2021-05-17 12:01:49,370 WARN  [io.und.servlet] (main) UT015020: Path /openapi/* is secured for some HTTP methods, however it is not secured for [TRACE, HEAD, DELETE, CONNECT, OPTIONS, PUT]
2021-05-17 12:01:49,995 INFO  [io.quarkus] (main) Quarkus 999-SNAPSHOT on JVM started in 2.976s. Listening on: https://localhost:8444
2021-05-17 12:01:49,995 INFO  [io.quarkus] (main) Profile test activated. 
2021-05-17 12:01:49,995 INFO  [io.quarkus] (main) Installed features: [cdi, resteasy, security, security-properties-file, servlet, smallrye-context-propagation, smallrye-openapi, swagger-ui]
2021-05-17 12:01:54,507 ERROR [io.und.req.io] (executor-thread-1) Exception handling request 05262ebb-6100-4426-8aab-3c94877102be-1 to /foo/: java.lang.NullPointerException: Cannot invoke "java.security.Principal.getName()" because the return value of "javax.servlet.http.HttpServletRequest.getUserPrincipal()" is null
	at io.quarkus.it.undertow.elytron.GreetingServlet.doPost(GreetingServlet.java:25)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:523)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:590)
	at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)

FYI @sberyozkin @stuartwdouglas ⬆️

@famod famod merged commit 1029450 into main May 17, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 17, 2021
@dependabot dependabot bot deleted the dependabot/maven/org.junit.jupiter-junit-jupiter-5.7.2 branch May 17, 2021 15:19
@gsmet
Copy link
Member

gsmet commented May 17, 2021

@sberyozkin I think we should have a look at this error as it looks very suspicious and it's not the first time I see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants