-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SmallRye Fault Tolerance 5.1.0 and add Vert.x integration #17328
Update to SmallRye Fault Tolerance 5.1.0 and add Vert.x integration #17328
Conversation
Draft because
|
Is this also going to fix the Java 16 issues? |
Indeed this will fix the Java 16 issues. I totally forgot to revert that commit -- thanks for reminder! |
9020019
to
f17592d
Compare
f17592d
to
490ca98
Compare
CI passed in my fork. |
@michalszynkiewicz could you please review the |
Have you tried running the tcks tests locally with Java 16? Thing is CI runs them only with Java 11. |
I did run the TCK locally with Java 16, but only on the SmallRye Fault Tolerance repo, that is, with Weld. Let me do that again with Quarkus. |
This is what I just did locally, on commit 490ca98, that is, on the branch corresponding to this PR: find . -type d -name target -print0 | xargs -0 rm -rf
mvn clean install -Dquickly
export JAVA_HOME=/usr/lib/jvm/java-16-openjdk-amd64
cd tcks/microprofile-fault-tolerance/
mvn clean verify -Dtcks And the result is In other words, the MP FT TCK passes on Java 16 just fine :-) |
Merging would certainly be nice :-) |
I mean, @cescoffier if you could take a look at what I did to the Vert.x extension, that would be even nicer! I couldn't think of a better place where to put the integration dependency. An unfortunate side effect is that the |
Thanks for checking the FT TCK on Java 16! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the new dependency is acceptable as it rather small. We can revisit this later if need be.
Fixes #17080