ArC dev mode - fix business method invocations monitoring #17354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a ConcurrentModificationException may be thrown if async processing and the request context is not propagated - resolves quarkusio#17322
gsmet
requested changes
May 19, 2021
| @@ -108,7 +109,8 @@ public String getPackageName(String name) { | |||
| private long start; | |||
| private long duration; | |||
| private Method method; | |||
| private List<Builder> children; | |||
| // If async processing and the request context is not propagated a new child can be added when/after the builder is built | |||
| private final List<Builder> children = new CopyOnWriteArrayList<>(); | |||
There was a problem hiding this comment.
Wouldn't it make more sense to have a volatile boolean called built or similar that is set to true at the very beginning of build() and exit from addChild() if it's true?
There was a problem hiding this comment.
I think that volatile would not be enough in this case, we would have to synchronize the access anyway. CopyOnWriteArrayList should be safe although not so efficient, but that should not be a big problem in the dev mode.
gsmet
approved these changes
May 19, 2021
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and the request context is not propagated