Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer: allow veto of default MeterRegistry #17536

Closed
wants to merge 1 commit into from
Closed

Micrometer: allow veto of default MeterRegistry #17536

wants to merge 1 commit into from

Conversation

ebullient
Copy link
Member

@ebullient ebullient commented May 29, 2021

Resolves #17481

Prefer #17570 to this one if the build is good.

@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2021

/cc @phillip-kruger

@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building fbe8174

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 8fffbd7

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 27a9cf6

Status Name Step Test failures Logs Raw logs
Native Tests - gRPC Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Native Tests - gRPC #

📦 integration-tests/grpc-streaming

io.quarkus.grpc.example.streaming.StreamingEndpointTest.testPipe line 30 - More details - Source on GitHub

@ebullient
Copy link
Member Author

ebullient commented May 30, 2021

@stuartwdouglas .. This approach works (and hides complexity from the other registry extensions) but @luneo7 asked if @UnlessBuildProperty should work here/be used instead. I made changes to try it, and while the @UnlessBuildProperty annotation was interpreted correctly (from what I could tell stepping through with the debugger), the producer method was still invoked (the registry instance was still created). I’d like to know what you think should be done here (with awareness that I would like this in Final…)

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 31, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building d21a3b1

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
Native Tests - Data4 Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP Set up JDK 11 ⚠️ Check → Logs Raw logs
Native Tests - Main Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security2 ⚠️ Check → Logs Raw logs
Native Tests - gRPC Reclaim Disk Space ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.export.NoDefaultPrometheusTest.testMeterRegistryPresent line 51 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.export.NoDefaultPrometheusTest.testMeterRegistryPresent line 47 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.export.NoDefaultPrometheusTest.testMeterRegistryPresent line 51 - More details - Source on GitHub

@ebullient ebullient requested a review from mkouba May 31, 2021 15:38
@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 418b9d0

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.export.NoDefaultPrometheusTest.testMeterRegistryPresent line 47 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.export.NoDefaultPrometheusTest.testMeterRegistryPresent line 47 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.export.NoDefaultPrometheusTest.testMeterRegistryPresent line 51 - More details - Source on GitHub

@mkouba
Copy link
Contributor

mkouba commented Jun 1, 2021

Superseded by #17570.

@mkouba mkouba closed this Jun 1, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 1, 2021
@ebullient ebullient deleted the vetoDefaultRegistry branch June 1, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/metrics triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using custom MeterRegistry implementations (aka suppressing the default MeterRegistry)
5 participants