Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SmallRye JWT 3.2.0 #17584

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Jun 1, 2021

The only reason it is 3.2.0 is because it includes MP JWT 1.2.1 - which itself only includes a few spec text and doc typo fixes and other minor text updates. Two JWT Build API optimizations are included as well

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jun 1, 2021
@sberyozkin
Copy link
Member Author

Propose for a backport just for 2.0.0.Final to include MP JWT 1.2.1 with the better experience for the users who may want to check JsonWebToken API Java docs without the fixed typos. Not critical though

@sberyozkin
Copy link
Member Author

I think this failure is not related, smallrye-jwt is not even loaded:

2021-06-01 10:11:55,252 INFO  [io.quarkus] (Quarkus Main Thread) acme 1.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 0.314s. Listening on: http://localhost:8080
2021-06-01T10:11:55.3824202Z 2021-06-01 10:11:55,252 INFO  [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated.
2021-06-01T10:11:55.3825712Z 2021-06-01 10:11:55,252 INFO  [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, resteasy, smallrye-context-propagation, websockets]
2021-06-01T10:11:55.3827085Z 2021-06-01 10:11:55,253 INFO  [io.qua.dep.dev.RuntimeUpdatesProcessor] (vert.x-worker-thread-1) Live reload total time: 0.404s 
2021-06-01T10:11:55.3921110Z [ERROR] Tests run: 44, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 697.606 s <<< FAILURE! - in io.quarkus.maven.it.DevMojoIT
2021-06-01T10:11:55.3930180Z [ERROR] io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed  Time elapsed: 73.837 s  <<< ERROR!
2021-06-01T10:11:55.3942914Z org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT that uses java.lang.String was not fulfilled within 1 minutes.
2021-06-01T10:11:55.3950369Z 	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 1, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 1, 2021

Failing Jobs - Building f422194

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16
Maven Tests - JDK 11 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 55 - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

@sberyozkin
Copy link
Member Author

vertx-http-deployment test has failed on Windows:

2021-06-01T10:04:24.1042405Z 2021-06-01 10:04:05,216 INFO  [io.quarkus] (Test runner thread) Quarkus stopped in 0.029s
2021-06-01T10:04:24.1043368Z 2021-06-01 10:04:05,240 ERROR [io.qua.test] (Test runner thread) ==================== TEST REPORT #1 ====================
2021-06-01T10:04:24.1044451Z 2021-06-01 10:04:05,240 ERROR [io.qua.test] (Test runner thread) Test SimpleET#testHelloEndpoint() failed 
2021-06-01T10:04:24.1045528Z : java.lang.AssertionError: 1 expectation failed.
2021-06-01T10:04:24.1046394Z Expected status code <200> but was <404>.
2021-06-01T10:04:24.1046861Z 
2021-06-01T10:04:24.1048495Z 	at io.restassured.internal.ValidatableResponseImpl.statusCode(ValidatableResponseImpl.groovy)
2021-06-01T10:04:24.1051567Z 	at io.quarkus.vertx.http.testrunner.brokenonly.SimpleET.testHelloEndpoint(SimpleET.java:21)

So if there are no objections then I'll merge

@sberyozkin sberyozkin merged commit 750f3c1 into quarkusio:main Jun 1, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 1, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 1, 2021
@sberyozkin sberyozkin deleted the smallrye-jwt-3.2.0 branch June 1, 2021 14:12
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.CR3 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants