Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - rework the way the build profile producer beans are disabled #17972

Merged
merged 1 commit into from
Jun 17, 2021
Merged

ArC - rework the way the build profile producer beans are disabled #17972

merged 1 commit into from
Jun 17, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 17, 2021

@mkouba mkouba added this to the 2.1 - main milestone Jun 17, 2021
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jun 17, 2021
@mkouba mkouba requested review from manovotn, geoand and Ladicek June 17, 2021 07:51
geoand
geoand approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and elegant!

manovotn
manovotn approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Ladicek
Ladicek approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it would look even better with a test :-)

@mkouba
Copy link
Contributor Author

mkouba commented Jun 17, 2021

Looks good, but it would look even better with a test :-)

We have plenty of tests for @IfBuildProfile and friends...

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2021
@Ladicek
Copy link
Contributor

Ladicek commented Jun 17, 2021

Fair enough :-) I was thinking this would be a user-facing API as well, but the indirect tests are probably fine.

@mkouba
Copy link
Contributor Author

mkouba commented Jun 17, 2021

Fair enough :-) I was thinking this would be a user-facing API as well, but the indirect tests are probably fine.

Yeah, I forgot to mention that I did not document this annotation because I'm not sure whether it will be of any use for app developers and extension authors...

@manovotn
Copy link
Contributor

Fair enough :-) I was thinking this would be a user-facing API as well, but the indirect tests are probably fine.

Yeah, I forgot to mention that I did not document this annotation because I'm not sure whether it will be of any use for app developers and extension authors...

That's a good point. Should we then put it under the impl package which should contain the "internals" not exposed to users?

@mkouba
Copy link
Contributor Author

mkouba commented Jun 17, 2021

Fair enough :-) I was thinking this would be a user-facing API as well, but the indirect tests are probably fine.

Yeah, I forgot to mention that I did not document this annotation because I'm not sure whether it will be of any use for app developers and extension authors...

That's a good point. Should we then put it under the impl package which should contain the "internals" not exposed to users?

So I've put the annotation intentionally in the io.quarkus.arc package as a "hidden" feature. I do admit that it's not very neat but I believe it's practical ;-).

@manovotn
Copy link
Contributor

So I've put the annotation intentionally in the io.quarkus.arc package as a "hidden" feature.

An untested hidden feature of Arc. How hideous of you :-D

@mkouba
Copy link
Contributor Author

mkouba commented Jun 17, 2021

So I've put the annotation intentionally in the io.quarkus.arc package as a "hidden" feature.

An untested hidden feature of Arc. How hideous of you :-D

Well, it's definitely not untested ;-)

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 17, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1b5a102

Status Name Step Test failures Logs Raw logs
⌛ MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@mkouba mkouba merged commit 05b3caa into quarkusio:main Jun 17, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@manovotn manovotn manovotn approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

ArC - rework the way the build profile/property producer beans are disabled
4 participants
@mkouba @Ladicek @manovotn @geoand