Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure suspend methods in RESTEasy Reactive use the same default media types as regular methods #18171

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Ensure suspend methods in RESTEasy Reactive use the same default media types as regular methods #18171

merged 1 commit into from
Jun 28, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 25, 2021

Fixes: #18145

@geoand geoand requested a review from stuartwdouglas June 25, 2021 14:13
@geoand geoand changed the title Ensure suspend methods in RESTEasy Reactive use the same default media types Ensure suspend methods in RESTEasy Reactive use the same default media types as regular methods Jun 25, 2021
@geoand geoand mentioned this pull request Jun 25, 2021
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 25, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 2e7852d

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ JVM Tests - JDK 11 Build Test failures Logs Raw logs
⌛ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs
✖ Native Tests - Data3 Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - gRPC Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/resteasy-reactive-kotlin/prod-mode

✖ io.quarkus.it.resteasy.reactive.kotlin.BlockingCoroutinesTest. - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/resteasy-reactive-kotlin/prod-mode

✖ io.quarkus.it.resteasy.reactive.kotlin.BlockingCoroutinesTest. - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 integration-tests/resteasy-reactive-kotlin/prod-mode

✖ io.quarkus.it.resteasy.reactive.kotlin.BlockingCoroutinesTest. - More details - Source on GitHub

evanchooly
evanchooly reviewed Jun 25, 2021
View reviewed changes
...prod-mode/src/test/kotlin/io/quarkus/it/resteasy/reactive/kotlin/BlockingCoroutinesTest.java
@@ -36,7 +36,7 @@ public void test() {

@Path("hello")
@Blocking
public Object hello(kotlin.coroutines.Continuation<?> cont) {
public Object hello(kotlin.coroutines.Continuation<? super Object> cont) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this test/class is here. Are we expecting folks to write java endpoint trying to use coroutines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this test is meant to test that an error is thrown at build time because of the use of @Blocking

@geoand geoand merged commit 4ebdb63 into quarkusio:main Jun 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 28, 2021
@geoand geoand deleted the #18145 branch June 28, 2021 06:05
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.1.Final Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly left review comments

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
2.0.1.Final
Development

Successfully merging this pull request may close these issues.

Wrong content-type when using Kotlin coroutines in RESTEasy Reactive
4 participants
@geoand @evanchooly @stuartwdouglas @gsmet