Show proper error when a @QuarkusTest is run from a non-Quarkus project dir
#18197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
changed the title
@QuarkusTest is run from a non-Quarkus project dir
aloubyansky
reviewed
Jun 28, 2021
test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java
Outdated
Show resolved
Hide resolved
…ct dir This change fixes the (not uncommon) case where the IDE picks the wrong working directory to launch the tests. Without this PR, Quarkus throws a totally un-actionable message regarding SmallRye Config's inability to expand the platform properties Fixes: quarkusio#18132 Co-authored-by: Alexey Loubyansky <[email protected]>
aloubyansky
approved these changes
Jun 28, 2021
aloubyansky
added
the
triage/waiting-for-ci
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 206fa95
|
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 93b91bf
|
gsmet
approved these changes
Jun 28, 2021
|
YW! I was hit by this myself a couple times and didn't know what to make of it... Then I saw the linked issue and realised that it's a general problem that needs addressing. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the (not uncommon) case where the IDE picks the wrong
working directory to launch the tests.
Without this PR, Quarkus throws a totally un-actionable message
regarding SmallRye Config's inability to expand the platform
properties
Fixes: #18132