Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a generated feature for resources #18259

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

stuartwdouglas
Copy link
Member

Just put the names in a file instead

Fixes #18252

Just put the names in a file instead
@stuartwdouglas
Copy link
Member Author

One of the original drivers behind the generated feature approach was simply that the graal artifacts were not in maven central, so you could not easily add them as a dependency. This has not been an issue for a long time, so we can start to change this approach if we are having issues with the generated method size.

@gsmet
Copy link
Member

gsmet commented Jun 30, 2021

Are we confident enough about having native tests testing that? Asking because it looks like something we should backport given a user reported it and it's rather blocking when you hit it.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 30, 2021

Failing Jobs - Building 3cc0267

Status Name Step Test failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

@stuartwdouglas
Copy link
Member Author

Native tests this, if you modify the build step to print an empty file you get failures in it/main (probably others as well).

@gsmet gsmet merged commit 8fe4284 into quarkusio:main Jul 1, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 1, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.1.Final Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodTooLargeException in NativeImageAutoFeatureStep.generateFeature
3 participants