-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OidcClient to accept String expires_in values #18415
Update OidcClient to accept String expires_in values #18415
Conversation
extensions/oidc-client/runtime/src/main/java/io/quarkus/oidc/client/runtime/OidcClientImpl.java
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. |
extensions/oidc-client/runtime/src/main/java/io/quarkus/oidc/client/runtime/OidcClientImpl.java
Outdated
Show resolved
Hide resolved
e5ded42
to
95a6fab
Compare
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. |
f3ea4bd
to
d233b01
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building f3ea4bd
|
Thanks @gastaldi, it should be most optimal, the way you have proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @geoand |
Thanks @gastaldi |
Fixes #18374
Standard expires_in value is a JSON number (long) however some providers may return it as JSON String. This PR, instead of immediately retrieving it as
Long
, casts it toLong
if the property is an instance ofLong
otherwise converts aString
representation toLong
.One of the
oidc_client_wiremock
tests has been updated to check it (there is another test there which deals with Long)CC @chiragrp