Don't close the connection when returning Multi

[stuartwdouglas]

Fixes #18445

[stuartwdouglas]

@FroMage @geoand any idea why this was here? It should not be necessary.

[geoand]

I personally don't

[FroMage]

Obviously it is necessary, otherwise it woudn't be there with a big fat comment. But I probably didn't know how to write a test for this, and I can't remember now. Let's fix it but please add a test that checks that we didn't close the connection?

And then when someone figures out something didn't work we'l get a reproducer for the original issue for free :)

[rasmusfaber]

Let's fix it but please add a test that checks that we didn't close the connection?

Feel free to use the test in https://github.com/rasmusfaber/quarkus-resteasy-reactive-connection-drop/blob/main/src/test/java/org/acme/getting/started/ReactiveGreetingResourceTest.java

It should be easy to modify it to fit into quarkus-integration-test-resteasy-mutiny (just change the endpoint) or I will be happy to make a pull request if you prefer.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5f120f8

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	Build	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.stream.StreamTestCase.testStreamingDoesNotCloseConnection line 78 - More details - Source on GitHub

---

⚙️ JVM Tests - JDK 16 #

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.stream.StreamTestCase.testStreamingDoesNotCloseConnection line 78 - More details - Source on GitHub

[stuartwdouglas]

Damnit, that test works on my machine

[FroMage]

Damnit, that test works on my machine

That's like 95% of my daily routine, man 🤣