Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC decorators - fix NPE when non-default delegate qualifiers are used #18637

Merged
merged 1 commit into from
Jul 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ protected void createConstructor(ClassOutput classOutput, ClassCreator creator,
ResultHandle delegateQualifiersHandle = constructor.newInstance(MethodDescriptor.ofConstructor(HashSet.class));
for (AnnotationInstance delegateQualifier : decorator.getDelegateQualifiers()) {
// Create annotation literal first
ClassInfo delegateQualifierClass = decorator.getDeployment().getInterceptorBinding(delegateQualifier.name());
ClassInfo delegateQualifierClass = decorator.getDeployment().getQualifier(delegateQualifier.name());
constructor.invokeInterfaceMethod(MethodDescriptors.SET_ADD, delegateQualifiersHandle,
annotationLiterals.process(constructor, classOutput, delegateQualifierClass, delegateQualifier,
Types.getPackageName(creator.getClassName())));
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package io.quarkus.arc.test.decorators.qualifiers;

import static org.junit.jupiter.api.Assertions.assertEquals;

import io.quarkus.arc.Arc;
import io.quarkus.arc.test.ArcTestContainer;
import io.quarkus.arc.test.MyQualifier;
import javax.annotation.Priority;
import javax.decorator.Decorator;
import javax.decorator.Delegate;
import javax.enterprise.context.ApplicationScoped;
import javax.enterprise.context.Dependent;
import javax.enterprise.util.AnnotationLiteral;
import javax.inject.Inject;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

public class DelegateQualifiersTest {

@RegisterExtension
public ArcTestContainer container = new ArcTestContainer(Converter.class, ToUpperCaseConverter.class,
TrimConverterDecorator.class, MyQualifier.class);

@Test
public void testDecoration() {
@SuppressWarnings("serial")
ToUpperCaseConverter converter = Arc.container()
.instance(ToUpperCaseConverter.class, new AnnotationLiteral<MyQualifier>() {
}).get();
assertEquals("HOLA!", converter.convert(" holA!"));
assertEquals(" HOLA!", converter.convertNoDelegation(" holA!"));
}

interface Converter<T> {

T convert(T value);

}

@MyQualifier
@ApplicationScoped
static class ToUpperCaseConverter implements Converter<String> {

@Override
public String convert(String value) {
return value.toUpperCase();
}

public String convertNoDelegation(String value) {
return value.toUpperCase();
}

}

@Dependent
@Priority(1)
@Decorator
static class TrimConverterDecorator implements Converter<String> {

@Inject
@MyQualifier
@Delegate
Converter<String> delegate;

@Override
public String convert(String value) {
return delegate.convert(value.trim());
}

}

}