Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka quick start generate projects with maven plugin #18724

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

ozangunalp
Copy link
Contributor

Use quarkus-maven-plugin:create with noCode option to create projects without generated resources and tests.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The QuickStart code will need to be updated

@ozangunalp ozangunalp force-pushed the kafka_quickstart_maven_nocode branch from 0f7f5ac to caac8b3 Compare July 15, 2021 18:05
@geoand
Copy link
Contributor

geoand commented Jul 16, 2021

General question not really tied to this PR: Should we not be pointing users to the Quarkus CLI for creating projects instead of the Maven goal?

@cescoffier
Copy link
Member

So, the question is: do we expect the users to have downloaded the CLI first?

At some point, we will need a multi-tabs widget providing all the solutions (cli, maven, gradle, code.quarkus.io). Easy to do if you have CSS skills.

The same will also apply when to mention the added dependency (maven, gradle groovy, gradle kotlin)

@cescoffier cescoffier merged commit ab9fdc9 into quarkusio:main Jul 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 16, 2021
@ozangunalp
Copy link
Contributor Author

At some point, we will need a multi-tabs widget providing all the solutions (cli, maven, gradle, code.quarkus.io). Easy to do if you have CSS skills.

👍 You beat me to this with time difference :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants