Arc - Add qualifier checks on non-binding and repeating qualifiers, make sure events cannot be selected with type variables #18861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
manovotn
changed the title
Ladicek
approved these changes
Jul 20, 2021
|
This workflow status is outdated as a new workflow run has been triggered. |
|
This workflow status is outdated as a new workflow run has been triggered. |
mkouba
reviewed
Jul 22, 2021
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/Qualifiers.java
Outdated
Show resolved
Hide resolved
...ndent-projects/arc/tests/src/test/java/io/quarkus/arc/test/event/select/EventSelectTest.java
Show resolved
Hide resolved
…ake sure events cannot be selected with type variables. Added tests are mostly copies of existing TCK tests.
|
@mkouba lambda is gone and tests now use good old try-catch block. Please review when you get the chance |
mkouba
approved these changes
Jul 22, 2021
mkouba
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are few fixes to align Arc closer with CDI specification.
The changes are surely not exhaustive, it is just a bunch of things @starksm64 found out while executing TCKs in Arc. I will send more PRs as we discover more issues.
All the tests are basically modified copies from TCK tests (usually just transformation to Arc test-style + addition of bean defining annotation to beans).