Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that rest-client and rest-client-reactive are not used together #18899

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 21, 2021

This has come up multiple times, with the latest being #18792

This should not be allowed, but I am not sure if there are any tricky situations that could cause this to fail.

cc @michalszynkiewicz @gsmet @sberyozkin @stuartwdouglas

@geoand geoand marked this pull request as draft July 21, 2021 14:35
@geoand geoand marked this pull request as ready for review July 21, 2021 17:56
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 21, 2021

Failing Jobs - Building 74580b2

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/panache/mongodb-panache/deployment

io.quarkus.mongodb.panache.mongoentity.MongoEntityTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration
	at org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$7(DockerClientProviderStrategy.java:215)
	at java.base/java.util.Optional.orElseThrow(Optional.java:408)
	at org.testcontainers.dockerclient.DockerClientProviderStrategy.getFirstValidStrategy(DockerClientProviderStrategy.java:207)
	at org.testcontainers.DockerClientFactory.getOrInitializeStrategy(DockerClientFactory.java:136)
	at org.testcontainers.DockerClientFactory.client(DockerClientFactory.java:178)
	at org.testcontainers.LazyDockerClient.getDockerClient(LazyDockerClient.java:14)
	at org.testcontainers.LazyDockerClient.authConfig(LazyDockerClient.java:12)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:310)
	at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:175)
	at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:95)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:6...

@geoand
Copy link
Contributor Author

geoand commented Jul 22, 2021

@sberyozkin can you also verify this?

@geoand geoand merged commit 590a49e into quarkusio:main Jul 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 23, 2021
@geoand geoand deleted the rest-client-conflict branch July 23, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants