Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev services cleanup #19075

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Dev services cleanup #19075

merged 1 commit into from
Jul 30, 2021

Conversation

stuartwdouglas
Copy link
Member

  • Don't restart in test mode, it slows down continuous testing
  • Processors only produce DevServicesConfigResultBuildItem, quarkus
    handles turning it into runtime config
  • If no changes are made Quarkus handles the cached config, so the
    processor does not have to

Fixes #19044

@stuartwdouglas stuartwdouglas mentioned this pull request Jul 29, 2021
Merged
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b9bb5ee

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.multiplepersistenceunits.MultiplePersistenceUnitsImportSqlHotReloadScriptTest.testImportSqlScriptHotReload - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:250)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacksUntilExceptionOccurs$5(TestMethodTestDescriptor.java:195)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeMethodsOrCallbacksUntilExceptionOccurs(TestMethodTestDescriptor.java:195)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachCallbacks(TestMethodTestDescriptor.java:158)
	at org.junit.jupite...

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.multiplepersistenceunits.MultiplePersistenceUnitsImportSqlHotReloadScriptTest.testImportSqlScriptHotReload - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:250)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacksUntilExceptionOccurs$5(TestMethodTestDescriptor.java:195)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeMethodsOrCallbacksUntilExceptionOccurs(TestMethodTestDescriptor.java:195)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachCallbacks(TestMethodTestDescriptor.java:158)
	at org.junit.jupite...

⚙️ JVM Tests - JDK 16 #

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.multiplepersistenceunits.MultiplePersistenceUnitsImportSqlHotReloadScriptTest.testImportSqlScriptHotReload - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusDevModeTest.beforeEach(QuarkusDevModeTest.java:250)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacksUntilExceptionOccurs$5(TestMethodTestDescriptor.java:195)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeMethodsOrCallbacksUntilExceptionOccurs(TestMethodTestDescriptor.java:195)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachCallbacks(TestMethodTestDescriptor.java:158)
	at org.junit.jupite...

@stuartwdouglas
Dev services cleanup
a62bdad 
- Don't restart in test mode, it slows down continuous testing
- Processors only produce DevServicesConfigResultBuildItem, quarkus
  handles turning it into runtime config
- If no changes are made Quarkus handles the cached config, so the
  processor does not have to

Fixes quarkusio#19044
@geoand
Copy link
Contributor

geoand commented Jul 30, 2021

CI is now green

@stuartwdouglas stuartwdouglas merged commit b60909c into quarkusio:main Jul 30, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 30, 2021
@stuartwdouglas stuartwdouglas mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/kafka area/mongodb area/oidc area/reactive-messaging area/redis area/smallrye area/testing area/vault
Projects
None yet
Milestone
2.2.0.CR1
Development

Successfully merging this pull request may close these issues.

Kafka dev services restarted for continuous testing
2 participants
@stuartwdouglas @geoand