Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinispan Dev UI without Infinispan configuration #19099

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

karesti
Copy link
Member

@karesti karesti commented Jul 29, 2021

When the configuration of infinispan is not provided, the Dev UI breaks

Without configuration:

Screenshot 2021-07-29 at 17 06 21

With configuration:

Screenshot 2021-07-29 at 17 06 32

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the PR, tried with / without running ISPN, some misconfigurations.

The only comment I have is for Web Console link. I was using both quay.io/infinispan/server and quay.io/infinispan/server-native. For server-native there is no web console available. Not sure if it's worth checking the availability of the console.

@karesti
Copy link
Member Author

karesti commented Jul 29, 2021

@rsvoboda yes, the lack of console in the native infinispan server is an issue that needs to be fixed in the infinispan server native but the web console is supposed to be always there cc @wburns

@karesti karesti force-pushed the fix-dev-mode-without-config branch from 945e6c1 to 5f31866 Compare July 29, 2021 22:18
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5f31866

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@geoand
Copy link
Contributor

geoand commented Jul 30, 2021

Seems like a formatting change is needed

@wburns
Copy link
Member

wburns commented Jul 30, 2021

@rsvoboda yes, the lack of console in the native infinispan server is an issue that needs to be fixed in the infinispan server native but the web console is supposed to be always there cc @wburns

I never trust anything is working with the ISPN native server, but what we test in CI. So I would say it is the Schrödinger's console :)

@gsmet gsmet force-pushed the fix-dev-mode-without-config branch from 5f31866 to 49c7e70 Compare August 2, 2021 09:33
@gsmet
Copy link
Member

gsmet commented Aug 2, 2021

Rebased and fixed the formatting issue.

@gsmet gsmet added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 2, 2021
@karesti
Copy link
Member Author

karesti commented Aug 2, 2021

@gsmet thanks for the formatting

@gsmet gsmet merged commit 848af56 into quarkusio:main Aug 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.1.Final Aug 3, 2021
@karesti karesti deleted the fix-dev-mode-without-config branch August 5, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants