Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue the log messages if the queue compaction leads to new space #19400

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Queue the log messages if the queue compaction leads to new space #19400

merged 1 commit into from
Aug 15, 2021

Conversation

jaikiran
Copy link
Member

Fixes #19381

As rightly noticed and debugged by the reporter in the linked issue, the QuarkusDelayedHandler has a return statement which prevents the log message(s) from being queued after a queue compaction has made available new space. This commit fixes that issue.

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Aug 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 14, 2021

Failing Jobs - Building c039d16

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: org.testcontainers.containers.ContainerLaunchException: Container startup failed
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:330)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311)
	at io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor.lambda$startKafka$6(DevServicesKafkaProcessor.java:224)
	at java.base/java.util.Optional.orElseGet(Optional.java:369)
	at io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor.startKafka(DevServicesKafkaProcessor.java:232)
	at io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor.startKafkaDevServ...

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Glad to have you back :).

@gsmet gsmet merged commit 9f42b6e into quarkusio:main Aug 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Aug 15, 2021
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.3.Final Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusDelayedHandler prints an error and throws a log message away even if the queue was compacted
2 participants