-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jandex-maven-plugin usage to gRPC Getting Started Guide #19441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to contribute. I added a couple of suggestions!
1a52e3a
to
bbf5493
Compare
bbf5493
to
c884f8c
Compare
People seem to be running into quarkusio#15057 (including myself) because a Jandex Index is missing, thus we should update the gRPC Getting Started Guide and mention this.
c884f8c
to
8023497
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 8023497
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/hibernate-reactive-panache✖
⚙️ JVM Tests - JDK 16 #📦 integration-tests/oidc-wiremock✖
✖
✖
✖
|
@michalszynkiewicz are the failed tests known flaky or something that broke due to my changes? |
Failures don't look related, I retriggered the tests. |
Failing Jobs - Building 8023497
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
|
Now it failed on a test that succeeded before. Again, this test doesn't look related to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
People seem to be running into
#15057 (including myself)
because a Jandex Index is missing, thus we should update the gRPC
Getting Started Guide and mention this.