-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability for extensions to exclude GraalVM config from jars #19649
Conversation
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
Outdated
Show resolved
Hide resolved
At a high level, keeping aside the 2 arg value comment that I added, I think we should perhaps make this |
@jaikiran yeah that makes sense, but I would first like @Sanne and @ppalaga to give it a try with the use cases they have in mind. Since we are only at the beginning of the 2.3 development cycle, we have plenty of time to improve on this. |
...oyment/src/main/java/io/quarkus/deployment/builditem/nativeimage/ExcludeConfigBuildItem.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle, but there's some changes that seem unrelated.
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
Outdated
Show resolved
Hide resolved
...oyment/src/main/java/io/quarkus/deployment/builditem/nativeimage/ExcludeConfigBuildItem.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, thanks. I do not think we have anything waiting urgently for this ATM.
@Sanne are you OK with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geoand yes sure. I was hoping to try it out as well, but couldn't get to that yet - I'll do it soon but it's no reason to hold you back.
👍🏼 |
Resolves: #17482