-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DevServices test integration #19666
Improve DevServices test integration #19666
Conversation
test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusIntegrationTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from a minor comment I added.
Sergey should of course vet the Keycloak stuff.
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d46b426
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/vault-app✖
⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-fault-tolerance✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartwdouglas Great stuff, thanks,KeycloakTestClient
is also a better name. I'll look at updating OIDC docs (and also update KC test factory which starts its own container to disable devservices as you proposed earlier) when this PR is merged
Also improce the KeyCloak test client, and modify a KC test to use DevServices. This adds a new DevServicesContext which can be injected into QuarkusTest and QuarkusIntegrationTest, as well as TestResourceManager implementation (to allow the dev service to be configured).
d46b426
to
fc697fc
Compare
Also improce the KeyCloak test client, and modify a KC test to use
DevServices.
This adds a new DevServicesContext which can be injected into
QuarkusTest and QuarkusIntegrationTest, as well as TestResourceManager
implementation (to allow the dev service to be configured).