Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set actual file name in Rest Client Reactive multipart support #19827

Merged

Conversation

michalszynkiewicz
Copy link
Member

@michalszynkiewicz michalszynkiewicz commented Sep 1, 2021

fixes #19805

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 1, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@michalszynkiewicz michalszynkiewicz changed the title Rest Client Reactive: Multipart file name set to actual filename for … Rest Client Reactive: Multipart file name set to actual filename for path and file Sep 1, 2021
@quarkus-bot quarkus-bot bot added the area/rest label Sep 1, 2021
@geoand geoand changed the title Rest Client Reactive: Multipart file name set to actual filename for path and file Set actual file name in Rest Client Reactive multipart support Sep 1, 2021
@geoand
Copy link
Contributor

geoand commented Sep 1, 2021

Can we have a test for this as well?

@michalszynkiewicz
Copy link
Member Author

Not easily. I cannot get to the name of the file from RestEasy Reactive (server side).
I also briefly looked at wiremock but it wasn't clear to me how to do it (now I understand the reporter of the issue who also had problems with this :) )

@geoand
Copy link
Contributor

geoand commented Sep 1, 2021

Wouldn't this fit the bill?
An example of using FileUpload can be found here.

@michalszynkiewicz
Copy link
Member Author

I'll try that, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 1, 2021

Failing Jobs - Building 55c8f01

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@michalszynkiewicz
Copy link
Member Author

I don't think the failure is related

@michalszynkiewicz michalszynkiewicz merged commit dc7af63 into quarkusio:main Sep 1, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 1, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.2.Final Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus RestEasy Reactive MultiFormData Client Upload Jar Issue
3 participants