-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubernetes-client-bom from 5.7.0 to 5.7.1 #19831
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building f72c1fe
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
📦 integration-tests/gradle/target/classes/basic-java-library-module/application✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
📦 integration-tests/gradle/target/classes/basic-java-library-module/application✖
⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/kubernetes-client integration-tests/kubernetes/quarkus-standard-way integration-tests/openshift-client
📦 integration-tests/kubernetes-client✖
✖
✖
✖
✖
✖
✖
✖
📦 integration-tests/kubernetes/quarkus-standard-way✖
✖
✖
✖
✖
📦 integration-tests/openshift-client✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/kubernetes-client integration-tests/kubernetes/quarkus-standard-way integration-tests/openshift-client
📦 integration-tests/kubernetes-client✖
✖
✖
✖
✖
✖
✖
✖
📦 integration-tests/kubernetes/quarkus-standard-way✖
✖
✖
✖
✖
📦 integration-tests/openshift-client✖
⚙️ JVM Tests - JDK 16 #- Failing: integration-tests/kubernetes-client integration-tests/kubernetes/quarkus-standard-way integration-tests/openshift-client
📦 integration-tests/kubernetes-client✖
✖
✖
✖
✖
✖
✖
✖
📦 integration-tests/kubernetes/quarkus-standard-way✖
✖
✖
✖
✖
📦 integration-tests/openshift-client✖
⚙️ Native Tests - Misc3 #- Failing: integration-tests/kubernetes-client integration-tests/openshift-client
📦 integration-tests/kubernetes-client✖ 📦 integration-tests/openshift-client✖ |
Signed-off-by: Marc Nuri <[email protected]>
f72c1fe
to
e7fd354
Compare
I rebased the branch, let's see how it behaves now that the main branch is also updated. I am not 100% sure if we can backport this PR without backporting the Jandex bump too |
Failing Jobs - Building e7fd354
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
Here's the interesting part: https://github.com/fabric8io/kubernetes-client/blob/v5.7.1/pom.xml#L612-L632. Fabric8 Kubernetes Client's POM explicitly says that the Jandex Maven plugin is not supposed to use the Jandex version it was built with, but the Jandex version the POM includes. So even though the Jandex Maven plugin is version 1.1.1, it used Jandex 2.4.0.Final. Jandex 2.4 writes indices of version 10, which Jandex 2.3 can't read. |
Is #14586 going to be backported? |
I don't think we should backport #14586. My personal opinion is that we also shouldn't backport the Jandex 2.4.0.Final upgrade, but I could be convinced otherwise, I guess :-) I'd recommend Fabric8 Kubernetes Client to downgrade Jandex back to 2.3.1.Final and re-release. I'm also writing down a Jandex compatibility promise, which unfortunately hasn't been done before. |
FYI, I'm trying to add an explicit compatibility promise to Jandex in this PR: smallrye/jandex#136 Comments welcome :-) |
Let's upgrade to 5.7.2, which uses Jandex 2.3.1 (meaning it's backportable). Closing this now |
Kubernetes Client 5.7.1 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v5.7.1
Just speeding up the dependabot process to see if CI reports any issue.
/cc @metacosm