Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GradleRunIntegrationTest (fixes #1623) #1985

Closed
wants to merge 8 commits into from
Closed

add GradleRunIntegrationTest (fixes #1623) #1985

wants to merge 8 commits into from

Conversation

vorburger
Copy link
Contributor

No description provided.

@vorburger
Copy link
Contributor Author

@stalep @geoand how do you like this? This implements (and closes, as a first version) #1623.

Review Tip: Look only at the last commit of this PR - everything else before that is "just" #1926 and #1929, which (in two steps) makes the currently badly broken devtools/gradle-it actually produce a working JAR, again.

This was referenced Apr 10, 2019
Closed
Merged
Closed
vorburger and others added 8 commits April 10, 2019 19:09
@vorburger
use 'plugins' instead of 'apply plugin' in gradle-it
81ced73 
related to quarkusio#1623

just for consistency with the Quick Start and our doc on
https://quarkus.io/guides/gradle-tooling and
https://quarkus.io/guides/gradle-config.html

FTR: This change does not actually fix the currently broken Gradle IT.
@vorburger
fix PR's CI build failure (hopefully)
d1daf83 
reproduced locally after wiping:
~/.m2/repository/javax/enterprise/cdi-api/
 ~/.m2/repository/commons-logging
~/.m2/repository/org/jboss/xnio
@vorburger
remove TODO in settings.gradle
fe138dd 
see details in discussion of PR
@vorburger
avoid using mavenLocal() in devtools/gradle-it
f0b5860 
see details for why in quarkusio#1926

related to quarkusio#1623
@vorburger
add jaxb-osgi exclusion for rest-assured to BOM (fixes quarkusio#1991)
0c5c340
@vorburger
fix gradle-it by changing build.gradle (and its POM) to be more like IRL
78113cb
@vorburger
add GradleRunIntegrationTest (fixes quarkusio#1623)
40da620
@vorburger
add missing <scope>test to JUnit in gradle-run-it POM
73fe4c2
@vorburger vorburger force-pushed the issue-1623_actually-add-gradle-it-run branch from 0aba9e2 to 73fe4c2 Compare April 10, 2019 17:12
@geoand
Copy link
Contributor

geoand commented Apr 10, 2019

@stalep @geoand how do you like this? This implements (and closes, as a first version) #1623.

Review Tip: Look only at the last commit of this PR - everything else before that is "just" #1926 and #1929, which (in two steps) makes the currently badly broken devtools/gradle-it actually produce a working JAR, again.

I haven't really followed the Gradle stuff lately so I can't really comment, sorry.

@stalep stalep mentioned this pull request Apr 11, 2019
Closed
@vorburger
Copy link
Contributor Author

It's a bit of a PITA to understand the root cause of the test failure, which happens only on Azure.

I'm hoping #1986 will helps to see it more clearly. Therefore abandoning this (#1986 includes this).

@vorburger vorburger closed this Apr 11, 2019
@gsmet gsmet added the triage/invalid This doesn't seem right label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vorburger @geoand @gsmet