Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in QuarkusTestExtension.runAfterAllCallbacks() on failed boot (2.2) #19993

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix NPE in QuarkusTestExtension.runAfterAllCallbacks() on failed boot (2.2) #19993

merged 1 commit into from
Sep 8, 2021

Conversation

famod
Copy link
Member

@famod famod commented Sep 8, 2021

@famod
Copy link
Member Author

famod commented Sep 8, 2021

/cc @gsmet because of excplicit backport.

@gsmet gsmet added this to the 2.2.3.Final milestone Sep 8, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, I attached the version manually.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2021

Failing Jobs - Building c58e113

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.BasicKotlinApplicationModuleDevModeTest.main line 18 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@famod
Copy link
Member Author

famod commented Sep 8, 2021

Those two JVM Tests are strangely cut off somehow, but the "JVM Tests - JDK 11" one passed, so...
And BasicKotlinApplicationModuleDevModeTest failed before, so it seems you fix was not enough @gsmet

Good to merge I think, any objections?

@famod famod merged commit 4ff9b61 into quarkusio:2.2 Sep 8, 2021
@famod famod deleted the npe-qte-2.2 branch September 8, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants