Rest Client Reactive: Support PathParam from BeanParam #20056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Sep 10, 2021
.../src/main/java/io/quarkus/jaxrs/client/reactive/deployment/JaxrsClientReactiveProcessor.java
Show resolved
Hide resolved
geoand
reviewed
Sep 10, 2021
...ve/deployment/src/test/java/io/quarkus/rest/client/reactive/beanparam/BeanPathParamTest.java
Outdated
Show resolved
Hide resolved
michalszynkiewicz
force-pushed
the
rest-client-reactive-support-path-param-from-bean-param
branch
from
e0122a2 to
9cc6a05
Compare
geoand
approved these changes
Sep 10, 2021
|
I believe we should backport this. WDYT? |
|
It feels safe. But TBH I'm under impression that passing path params in |
|
But if you think it's important enough, I don't mind :) |
|
Let's just keep it mind |
|
I already added the backport label :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20027